Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): reassign topic #818

Merged
merged 2 commits into from
Dec 11, 2023
Merged

feat(controller): reassign topic #818

merged 2 commits into from
Dec 11, 2023

Conversation

ShadowySpirits
Copy link
Contributor

Transfer one queue from node 1 to node 2 in 1s (without updating dirty data to S3).

image

Signed-off-by: SSpirits <admin@lv5.moe>
Signed-off-by: SSpirits <admin@lv5.moe>
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #818 (bf2c3cb) into main (fa5a4b1) will decrease coverage by 1.36%.
The diff coverage is 44.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #818      +/-   ##
============================================
- Coverage     56.65%   55.29%   -1.36%     
+ Complexity     1263     1236      -27     
============================================
  Files           132      132              
  Lines          8485     8516      +31     
  Branches        782      784       +2     
============================================
- Hits           4807     4709      -98     
- Misses         3239     3392     +153     
+ Partials        439      415      -24     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.75% <46.80%> (-4.05%) ⬇️
RocketMQ Proxy 37.56% <ø> (ø)
RocketMQ Store 74.28% <0.00%> (-0.15%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)
Files Coverage Δ
...java/com/automq/rocketmq/common/api/DataStore.java 0.00% <ø> (ø)
...mq/rocketmq/controller/server/tasks/LeaseTask.java 65.33% <0.00%> (-1.34%) ⬇️
...ava/com/automq/rocketmq/store/DataStoreFacade.java 0.00% <0.00%> (ø)
.../controller/server/store/DefaultMetadataStore.java 63.05% <47.82%> (-4.15%) ⬇️

... and 15 files with indirect coverage changes

@ShadowySpirits ShadowySpirits merged commit 0716d7f into main Dec 11, 2023
12 of 14 checks passed
@ShadowySpirits ShadowySpirits deleted the reassign_topic branch December 11, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant